-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade components #1677
base: alpha
Are you sure you want to change the base?
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to hear it works with npm and we don't need yarn after all.
When you do the changes, especially removing the range operators, you may want to do that in batches, delete package-lock
and node_modules
and run npm i
in between, because that may be what has caused the install to fail previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is somewhat surprising that despite the update of so many dependencies, sometimes by several major versions, virtually no code changes were necessary.
The CI will easily pass because Parse Dashboard does not seem to be tested for functionality, so this seems suspicious to me. I think it would be good to test this thoroughly by hand before merging.
@romanbsd Did you use npm 7 when you had this issue, and now it is working because you use npm 6? |
What should we do with this PR? I'm concerned about the many major version upgrades in the dependencies without any significant code changes in dashboard. It's possible that we are breaking something and don't notice it, unless we go through the dashboard and test some functionality I guess. |
It's up to you what to do about this PR. For me it was the first step before trying to modernize the project and bring the components to the latest recommended practices. It was working for me (tm), but this definitely needs more testing. |
It this PR in response to #1679? |
This PR is a preparation for #1761 |
Besides upgrading the components, it also has one bugfix: |
It's related, as it's a first step for 1679. But this PR can be reviewed in isolation. It's not related per se, and was opened before. |
I suppose we could proceed this way:
@romanbsd would you want to do (1)? Then I would take care of (2). |
This updates the dependencies to the latest versions and fixes few bugs and warnings.
I switched from npm to yarn since npm was not able to resolve dependencies.
It needs testing in the graphql area.