Using the encoder on state is too broad.

[rogerhu]

Related to issue: #14

Currently only the conditions and class name are encoded:

https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/blob/master/Sources/ParseLiveQuery/Internal/QueryEncoder.swift

Based obviously on: https://github.com/ParsePlatform/parse-server/wiki/Parse-LiveQuery-Protocol-Specification

@mmimeault @flovilmart

[mmimeault]

Ok so as I understand you disable the encoding of the other states? Like the orderByAscending mentioned in the issue #14?

It make sense as the protocol only support className, where, but what about "fields": ["name"] // Optional ?

Thanks

[flovilmart]

We could also solve it server side, not reject those fields, and in the future, add support for those.

[rogerhu]

Yeah I don't see how fields is being used in the iOS version at this point. It feels like a separate issue.

Is it a matter of encoding selectKeys()?

Does fields also work for dotted notation?

[flovilmart]

@rogerhu fields doesn't filter server side IIRC

[rogerhu]

state.toJSON uses this function: https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseQuery.java#L831-L864

whereas the where corresponds to the constraints() function: https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseQuery.java#L778-L780

[mmimeault]

Ok. mm so what is the conclusion, fine like that for now? Or we should include fields?

[rogerhu]

It sounds like we shouldn't include fields for now. We could add it as selectKeys manually but it doesn't even work on the Parse server. And the iOS version doesn't even include fields so we should decide whether we should add support in a different Pr.

[mmimeault]

I think I'm fine with this PR for now. But we should "note" somewhere that fields is not supported by the server and neither by the SDK, so we know we have to do it later. (not forget)

[rogerhu]

Done: parse-community/parse-server#3671.
Added comment too