isNullPage is a function, not a method, since receiver is unused

parquet-go · Sep 23, 2024 · 8bb75a2 · 8bb75a2
1 parent af3266d
commit 8bb75a2
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/column_index.go b/column_index.go
@@ -99,24 +99,20 @@ func (i fileColumnIndex) NullCount(j int) int64 {
 }
 
 func (i fileColumnIndex) NullPage(j int) bool {
-	return i.nullPage(j, i.columnIndex())
-}
-
-func (i fileColumnIndex) nullPage(j int, index *format.ColumnIndex) bool {
-	return len(index.NullPages) > 0 && index.NullPages[j]
+	return isNullPage(j, i.columnIndex())
 }
 
 func (i fileColumnIndex) MinValue(j int) Value {
 	index := i.columnIndex()
-	if i.nullPage(j, index) {
+	if isNullPage(j, index) {
 		return Value{}
 	}
 	return i.makeValue(index.MinValues[j])
 }
 
 func (i fileColumnIndex) MaxValue(j int) Value {
 	index := i.columnIndex()
-	if i.nullPage(j, index) {
+	if isNullPage(j, index) {
 		return Value{}
 	}
 	return i.makeValue(index.MaxValues[j])
@@ -136,6 +132,10 @@ func (i *fileColumnIndex) makeValue(b []byte) Value {
 
 func (i fileColumnIndex) columnIndex() *format.ColumnIndex { return i.chunk.columnIndex.Load() }
 
+func isNullPage(j int, index *format.ColumnIndex) bool {
+	return len(index.NullPages) > 0 && index.NullPages[j]
+}
+
 type emptyColumnIndex struct{}
 
 func (emptyColumnIndex) NumPages() int       { return 0 }