-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner hash of value support. #134
Conversation
resolving is way more straight forward.
asumption on stored data.
meta for all nodes).
@@ -1625,11 +1776,4 @@ mod tests { | |||
test_comb((0, &a), (1, &b), (1, &[0x01, 0x23, 0x46, 0x78][..])); | |||
test_comb((1, &a), (1, &b), (0, &[0x23, 0x46, 0x78][..])); | |||
} | |||
|
|||
#[test] | |||
fn nice_debug_for_node() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed due to absence of an easy way to have a Layout with a u32 hash.
(could switch back to having Node instead of Node, but switching to Node is something I did a few time in the past so I did not revert those changes, but doable).
To reviewers, looking at current changes, 'Meta' in trielayout seems a bit awkward, I therefore recreate a branch with a inner meta type: This is more changes, but I generally find the typing better. |
After an internal discussion we've agreed to try a different approach. Values will be stored as plain data in |
Hello everyone, I'm just curious if this PR is still relevant? 🤔 Thanks!! |
No, it was superseded by #142, thanks for noticing it. |
This PR allows Inner hash of value support and metadata storage.
Inner hash of value
The triedbmut code change to allow hash of value instead of value:
enum
Value
replacesOption<DBValue>
.When accessing hash, then
HashDB
trait allows querying for value throughaccess_from
hashdb new function, but at this point it only acts ascallback of value access (since in all hashdb implementation values kept
being stored with their encoded node).
Notes for reviewers
register_proof_without_value
of triedbmut is new though.Variant branch: cheme/trie@hashed-value-simple4...cheme:hashed-value-simple4-meta-trait
TODOs