-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all deps to workspace toml #932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just remove some unintended committed files and it should be ready to go
Comment moved and added files gone :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated that; I assume it's used to determine the deps to download for tests so maybe good to keep it to ensure complete consistency between us :)
Move all of our dependencies (and version) to the workspace toml, and reference them in crates where used.
Why?
Note:
package = "parity-scale-codec"
is needed in each crate, because the macro uses https://github.com/bkchr/proc-macro-crate, which relies on finding that key in the local TOML (see bkchr/proc-macro-crate#34). The alternative is giving a manual crate path in all uses of the macro, but doesn't seem worth it.