Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all deps to workspace toml #932

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Move all deps to workspace toml #932

merged 6 commits into from
Apr 26, 2023

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Apr 25, 2023

Move all of our dependencies (and version) to the workspace toml, and reference them in crates where used.

Why?

  • Prevents dupe versions of crates from being used across the workspace (or, makes it very much "opt-in" and explicit if you do need this)
  • Makes bumping Subxt versions easy for releasing; just one file to change
  • Makes bumping Substrate dep versions easier; all in one place.
  • Makes it clear how many crates we import in total; might motivate us to cut down a bit ;)

Note: package = "parity-scale-codec" is needed in each crate, because the macro uses https://github.com/bkchr/proc-macro-crate, which relies on finding that key in the local TOML (see bkchr/proc-macro-crate#34). The alternative is giving a manual crate path in all uses of the macro, but doesn't seem worth it.

@jsdw jsdw requested a review from a team as a code owner April 25, 2023 16:02
@jsdw jsdw requested a review from a team April 25, 2023 17:06
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just remove some unintended committed files and it should be ready to go

@jsdw
Copy link
Collaborator Author

jsdw commented Apr 26, 2023

Comment moved and added files gone :)

Copy link
Member

@niklasad1 niklasad1 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated that; I assume it's used to determine the deps to download for tests so maybe good to keep it to ensure complete consistency between us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants