Make EventSubscription and FilterEvents Send-able #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Mar 7, 2022
subxt/src/rpc.rs
Outdated
| convert::TryInto, | ||
| marker::PhantomData, | ||
| }; | ||
| use core::convert::TryInto; |
There was a problem hiding this comment.
Can we get rid of this import too now because edition 2021?
ascjones
approved these changes
Mar 7, 2022
|
I can confirm that it works now, thank you! |
|
Thank you ! |
lexnv
approved these changes
Mar 8, 2022
lemarier
pushed a commit
to tidelabs/subxt
that referenced
this pull request
Mar 9, 2022
* Make EventSubscription and FilterEvents Send-able * Cargo fmt * clippy * Remove unused import
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, they cannot be used in
tokio::spawn-like contexts, which require things held across await points to implSend(because they might be moved across threads between such points).Closes #469