-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparation for v0.18.0 #464
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
CHANGELOG.md
Outdated
|
||
### Added | ||
|
||
- Reference key storage api ([#447](https://github.com/paritytech/subxt/pull/447)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd definitely put this in Changed
. E.g. my existing code would break where I have calls to storage with pass by value keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, will change right away
Signed-off-by: Alexandru Vasile <[email protected]>
CHANGELOG.md
Outdated
### Added | ||
|
||
- Filter one or multiple events by type from an EventSubscription ([#461](https://github.com/paritytech/subxt/pull/461)) | ||
- Distinct handling for N fields + 1 hasher vs N fields + N hashers ([#458](https://github.com/paritytech/subxt/pull/458)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really an addition; just a bugfix :) I'd whack it in Changes
CHANGELOG.md
Outdated
|
||
- Filter one or multiple events by type from an EventSubscription ([#461](https://github.com/paritytech/subxt/pull/461)) | ||
- Distinct handling for N fields + 1 hasher vs N fields + N hashers ([#458](https://github.com/paritytech/subxt/pull/458)) | ||
- Add hardcoded override to ElectionScore ([#455](https://github.com/paritytech/subxt/pull/455)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually was just a temporary fix before #456 was done; I's stick it in Changes or remove it entirely (since it was replaced)
CHANGELOG.md
Outdated
- Distinct handling for N fields + 1 hasher vs N fields + N hashers ([#458](https://github.com/paritytech/subxt/pull/458)) | ||
- Add hardcoded override to ElectionScore ([#455](https://github.com/paritytech/subxt/pull/455)) | ||
- Expose method to fetch nonce via `Client` ([#451](https://github.com/paritytech/subxt/pull/451)) | ||
- New Event Subscription API ([#442](https://github.com/paritytech/subxt/pull/442)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaced the old event subscription API, so probably a Change rather than an add too :)
I'd probably bundle this together with #461, above, and have both in Changes, since they both are part of this new event subscription api :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from shifting things into the Changed section lgtm :)
- Substitute BTreeMap/BTreeSet generated types for Vec ([#459](https://github.com/paritytech/subxt/pull/459)) | ||
- Obtain DispatchError::Module info dynamically ([#453](https://github.com/paritytech/subxt/pull/453)) | ||
- Add hardcoded override to ElectionScore ([#455](https://github.com/paritytech/subxt/pull/455)) | ||
- DispatchError::Module is now a tuple variant in latest Substrate ([#439](https://github.com/paritytech/subxt/pull/439)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one could be considered a fix or even an addition (compatibility with a new version of substrate while maintaining backwards compat), but I'm not sure myself so fine as a change.
Release preparation for v0.18.0