Make system properties an arbitrary JSON object, plus CI fixes #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Dec 2, 2021
niklasad1
approved these changes
Dec 2, 2021
ascjones
commented
Dec 2, 2021
I don't think it matters anyway, let's ignore my comment :D |
18 tasks
dvdplm
approved these changes
Dec 2, 2021
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
ascjones
changed the title
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
…ytech#349) * Make system properties an arbitrary JSON object * Add comment * Make timestamp test more reliable * Fmt * Update src/client.rs Co-authored-by: David <[email protected]> * Update src/client.rs Co-authored-by: David <[email protected]> * Fix clippy errors and warnings * Fix tests Co-authored-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #316.
System properties are just an arbitrary JSON object defined in the chainspec, so this should be reflected in
subxt. See https://github.com/paritytech/substrate/blob/b7409a2257c7c231b485ee827daa73d05d303047/client/chain-spec/src/lib.rs#L148Additionally to satisfy CI: