Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame-decode for core extrinsic decode logic #1785

Merged
merged 19 commits into from
Oct 1, 2024
Merged
Prev Previous commit
Next Next commit
Fix a couple of tests
  • Loading branch information
jsdw committed Sep 26, 2024
commit ffafbf2f84f04e651baa0ed8d5a359b5be8dc7fb
1 change: 0 additions & 1 deletion subxt/examples/blocks_subscribing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
println!(" Signed Extensions:");
if let Some(signed_extensions) = ext.signed_extensions() {
for signed_extension in signed_extensions.iter() {
let signed_extension = signed_extension?;
let name = signed_extension.name();
let value = signed_extension.value()?.to_string();
println!(" {name}: {value}");
Expand Down
4 changes: 2 additions & 2 deletions testing/integration-tests/src/full_client/blocks/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -351,12 +351,12 @@ async fn decode_signed_extensions_from_blocks() {

assert_eq!(extensions1.iter().count(), expected_signed_extensions.len());
for (e, expected_name) in extensions1.iter().zip(expected_signed_extensions.iter()) {
assert_eq!(e.unwrap().name(), *expected_name);
assert_eq!(e.name(), *expected_name);
}

assert_eq!(extensions2.iter().count(), expected_signed_extensions.len());
for (e, expected_name) in extensions2.iter().zip(expected_signed_extensions.iter()) {
assert_eq!(e.unwrap().name(), *expected_name);
assert_eq!(e.name(), *expected_name);
}

// check that era decodes:
Expand Down
Loading