Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subxt: Derive std::cmp traits for subxt payloads and addresses #1429

Merged
merged 9 commits into from
Feb 13, 2024
Merged

subxt: Derive std::cmp traits for subxt payloads and addresses #1429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
98c9ab7
subxt/tx: Derive std::cmp traits
lexnv Feb 12, 2024
271e881
subxt/runtime_api: Derive std::cmp traits
lexnv Feb 12, 2024
db2fac3
subxt/constants: Derive std::cmp traits
lexnv Feb 12, 2024
329bab9
subxt/custom_values: Derive std::cmp traits
lexnv Feb 12, 2024
890c051
subxt/storage: Derive std::cmp traits
lexnv Feb 12, 2024
eed11c5
subxt: Fix non_canonical_partial_ord_impl clippy introduced in 1.73
lexnv Feb 12, 2024
e4b5959
subxt: Add comment wrt derivative issue that triggers clippy warning
lexnv Feb 13, 2024
3699a90
Update subxt/src/backend/mod.rs
niklasad1 Feb 13, 2024
72ea9be
Update subxt/src/constants/constant_address.rs
niklasad1 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions subxt/src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ impl<H: PartialEq> PartialEq for BlockRef<H> {
}
impl<H: Eq> Eq for BlockRef<H> {}

// Manual implementation to work aroud https://github.com/mcarton/rust-derivative/issues/115.
niklasad1 marked this conversation as resolved.
Show resolved Hide resolved
impl<H: PartialOrd> PartialOrd for BlockRef<H> {
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
self.hash.partial_cmp(&other.hash)
Expand Down
1 change: 1 addition & 0 deletions subxt/src/constants/constant_address.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ pub struct Address<ReturnTy> {
_marker: std::marker::PhantomData<ReturnTy>,
}

// Manual implementation to work aroud https://github.com/mcarton/rust-derivative/issues/115.
niklasad1 marked this conversation as resolved.
Show resolved Hide resolved
impl<ReturnTy> PartialOrd for Address<ReturnTy> {
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
Some(self.cmp(other))
Expand Down
Loading