-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Run cronjob with app secrets #1420
Conversation
I turned this into a draft since it looks like it's in progress; please turn back to proper PR once it's ready for us to look at (I'm not sure the exact goals/reason for this change atm!) :) |
@jsdw thanks! I updated PR description @tadeohepperle the credentials work but now the action fails because of the error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for the help here!
I would probably also strip the binary, similarly to what Niklas suggested.
What would be the next step to get this merged? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice one!
I guess we can compress the other two polkadot binaries if we feel the need as well, but if it works at the mo then all good :)
PR adds app tokens so the job "Upload artifacts" has running CI in the PR it creates.
cc https://github.com/paritytech/ci_cd/issues/928
cc @tadeohepperle @pavelsupr