Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run cronjob with app secrets #1420

Merged
merged 15 commits into from
Feb 14, 2024
Merged

[ci] Run cronjob with app secrets #1420

merged 15 commits into from
Feb 14, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Feb 9, 2024

PR adds app tokens so the job "Upload artifacts" has running CI in the PR it creates.

cc https://github.com/paritytech/ci_cd/issues/928
cc @tadeohepperle @pavelsupr

@alvicsam alvicsam requested review from a team as code owners February 9, 2024 11:22
@jsdw jsdw marked this pull request as draft February 9, 2024 11:58
@jsdw
Copy link
Collaborator

jsdw commented Feb 9, 2024

I turned this into a draft since it looks like it's in progress; please turn back to proper PR once it's ready for us to look at (I'm not sure the exact goals/reason for this change atm!) :)

@alvicsam
Copy link
Contributor Author

alvicsam commented Feb 9, 2024

@jsdw thanks! I updated PR description

@tadeohepperle the credentials work but now the action fails because of the error:

remote: error: Trace: 7feebb3939405d32c7ba980df6692009a70fa25f7beea09036fe2722b667b968        
remote: error: See https://gh.io/lfs for more information.        
remote: error: File polkadot is 123.89 MB; this exceeds GitHub's file size limit of 100.00 MB        
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com./

Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for the help here!
I would probably also strip the binary, similarly to what Niklas suggested.

What would be the next step to get this merged? 🤔

@tadeohepperle tadeohepperle marked this pull request as ready for review February 14, 2024 08:26
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice one!

I guess we can compress the other two polkadot binaries if we feel the need as well, but if it works at the mo then all good :)

@tadeohepperle tadeohepperle merged commit e783d9f into master Feb 14, 2024
13 checks passed
@tadeohepperle tadeohepperle deleted the as-ci branch February 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants