Fix Update Artifacts Cronjob #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Jan 22, 2024
| run: cargo build --bin artifacts | ||
| run: cargo run --bin artifacts | ||
|
|
||
| - name: Delete substrate node binary |
There was a problem hiding this comment.
My understanding is that this CI job:
- checks our branch
- downloads substrate-node binary to help make changes
- opens PR to capture any changes.
And since we don't want the substrate-node binary to be a part of this PR we delete it first
There was a problem hiding this comment.
It is exactly like James said, without removing the substrate-node it will be added to the PR like it happened today in the morning.
niklasad1
approved these changes
Jan 22, 2024
lexnv
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original cronjob was not running properly and also pushed the substrate node itself into the PR.
I also simplified the scrips code to make it easier to get errors reported.
Here is the first PR generated by this branch: #1391