cargo: Switch to workspace lints #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
This reverts commit cdf9e16.
Signed-off-by: Alexandru Vasile <[email protected]>
niklasad1
reviewed
Dec 1, 2023
niklasad1
reviewed
Dec 1, 2023
Cargo.toml
Outdated
| while_true = "deny" | ||
| trivial_casts = "deny" | ||
| trivial_numeric_casts = "deny" | ||
| unused_crate_dependencies = "deny" |
There was a problem hiding this comment.
I suggest that we remove these unused crate lints and use cargo machete instead
There was a problem hiding this comment.
I like this a lot! Already discovered few unused crates, with the tradeoff of some false-positive subxt dependency used by our build.rs for the testing crate! Have also added a CI step for it!
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
niklasad1
reviewed
Dec 1, 2023
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
tadeohepperle
added a commit
that referenced
this pull request
Dec 4, 2023
* subxt: Remove unstable lints that cause compile warnings Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Switch to workspace lints Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Fix codec package at root level Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Move profiles to the root level Signed-off-by: Alexandru Vasile <[email protected]> * Fix lightclient and metadata crates Signed-off-by: Alexandru Vasile <[email protected]> * Revert "cargo: Fix codec package at root level" This reverts commit cdf9e16. * Fix complexity clippy Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Remove lints to be replaced by `cargo machete` Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Remove unused dependencies (detected by machete) Signed-off-by: Alexandru Vasile <[email protected]> * ci: Add machete step Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Bump rust version Signed-off-by: Alexandru Vasile <[email protected]> * ci: Rename machete step Signed-off-by: Alexandru Vasile <[email protected]> * ci: Rename cargo machete step Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
pushed a commit
that referenced
this pull request
Dec 6, 2023
…or` (#1306) * cargo: Switch to workspace lints (#1299) * subxt: Remove unstable lints that cause compile warnings Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Switch to workspace lints Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Fix codec package at root level Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Move profiles to the root level Signed-off-by: Alexandru Vasile <[email protected]> * Fix lightclient and metadata crates Signed-off-by: Alexandru Vasile <[email protected]> * Revert "cargo: Fix codec package at root level" This reverts commit cdf9e16. * Fix complexity clippy Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Remove lints to be replaced by `cargo machete` Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Remove unused dependencies (detected by machete) Signed-off-by: Alexandru Vasile <[email protected]> * ci: Add machete step Signed-off-by: Alexandru Vasile <[email protected]> * cargo: Bump rust version Signed-off-by: Alexandru Vasile <[email protected]> * ci: Rename machete step Signed-off-by: Alexandru Vasile <[email protected]> * ci: Rename cargo machete step Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]> * test and outer enum pre compute * explicit OuterEnumHashes type * clippy * move outer enums to their own module --------- Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the recommended rust best practices are followed (since rust 1.74.0):
declares the lints at the workspace level.
remove a couple of lints that are now declared as unstable.
the optimization profile of the light-client is moved at the root level