Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve some error messages #1183

Merged
merged 2 commits into from
Oct 2, 2023
Merged

chore: improve some error messages #1183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6178035
chore: improve some error messages
yjhmelody Sep 30, 2023
dcdae89
Merge branch 'master' into chore-improve-error-message
tadeohepperle Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions subxt/src/error/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ pub enum Error {
#[error("Serde json error: {0}")]
Serialization(#[from] serde_json::error::Error),
/// Error working with metadata.
#[error("Metadata: {0}")]
#[error("Metadata error: {0}")]
Metadata(#[from] MetadataError),
/// Error decoding metadata.
#[error("Metadata: {0}")]
#[error("Metadata Decoding error: {0}")]
MetadataDecoding(#[from] MetadataTryFromError),
/// Runtime error.
#[error("Runtime error: {0:?}")]
#[error("Runtime error: {0}")]
Runtime(#[from] DispatchError),
/// Error decoding to a [`crate::dynamic::Value`].
#[error("Error decoding into dynamic value: {0}")]
Expand All @@ -60,7 +60,7 @@ pub enum Error {
#[error("Transaction error: {0}")]
Transaction(#[from] TransactionError),
/// Error constructing the appropriate extrinsic params.
#[error("{0}")]
#[error("Extrinsic params error: {0}")]
ExtrinsicParams(#[from] ExtrinsicParamsError),
/// Block related error.
#[error("Block error: {0}")]
Expand All @@ -73,7 +73,7 @@ pub enum Error {
Unknown(Vec<u8>),
/// Light client error.
#[cfg(feature = "unstable-light-client")]
#[error("An error occurred but it could not be decoded: {0:?}")]
#[error("An error occurred but it could not be decoded: {0}")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested to know if this is something you've encountered in the wild

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[error("An error occurred but it could not be decoded: {0}")]
#[error("Light Client error: {0}")]

LightClient(#[from] LightClientError),
/// Other error.
#[error("Other error: {0}")]
Expand Down Expand Up @@ -110,7 +110,7 @@ pub enum RpcError {
ClientError(Box<dyn std::error::Error + Send + Sync + 'static>),
/// This error signals that the request was rejected for some reason.
/// The specific reason is provided.
#[error("RPC error: request rejected")]
#[error("RPC error: request rejected: {0}")]
RequestRejected(String),
/// The RPC subscription dropped.
#[error("RPC error: subscription dropped.")]
Expand Down