add note about UncheckedExtrinsic in default substitutes

paritytech · Nov 21, 2023 · 03591a6 · 03591a6
1 parent f47fd4e
commit 03591a6
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/codegen/Cargo.toml b/codegen/Cargo.toml
@@ -36,6 +36,4 @@ scale-typegen = { git = "https://github.com/paritytech/scale-typegen", branch =
 getrandom = { workspace = true, optional = true }
 
 [dev-dependencies]
-bitvec = { workspace = true }
 scale-info = { workspace = true, features = ["bit-vec"] }
-pretty_assertions = { workspace = true }
diff --git a/codegen/src/lib.rs b/codegen/src/lib.rs
@@ -336,6 +336,8 @@ fn default_substitutes(crate_path: &syn::Path) -> TypeSubstitutes {
         // The inner bytes represent the encoded extrinsic, however when deriving the
         // `EncodeAsType` the bytes would be re-encoded. This leads to the bytes
         // being altered by adding the length prefix in front of them.
+
+        // Note: Not sure if this is appropriate or not. The most recent polkadot.rs file does not have these.
         (
             parse_quote!(sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic),
             parse_quote!(#crate_path::utils::UncheckedExtrinsic),