Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move proxies migration #7205

Merged
9 commits merged into from
Sep 25, 2020
Merged

Move proxies migration #7205

9 commits merged into from
Sep 25, 2020

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Sep 24, 2020

This PR moves the time delayed proxy migration from on_runtime_upgrade to a freestanding function in order to not trigger the migration on every runtime upgrade that uses this pallet.

@apopiak apopiak added A0-please_review Pull request needs code review. B7-runtimenoteworthy C3-medium PR touches the given topic and has a medium impact on builders. labels Sep 24, 2020
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right to me. @bkchr @gnunicorn ?

frame/proxy/src/lib.rs Show resolved Hide resolved
frame/proxy/src/lib.rs Show resolved Hide resolved
@apopiak
Copy link
Contributor Author

apopiak commented Sep 25, 2020

thanks for the docs Shawn!

@apopiak
Copy link
Contributor Author

apopiak commented Sep 25, 2020

bot merge

@ghost
Copy link

ghost commented Sep 25, 2020

Trying merge.

@ghost ghost merged commit b510b85 into master Sep 25, 2020
@ghost ghost deleted the apopiak-move-proxies-migration branch September 25, 2020 09:11
@apopiak
Copy link
Contributor Author

apopiak commented Nov 10, 2020

Note: If using the introduced migration function, you should use storage guards to make sure it
only runs once.

@apopiak apopiak mentioned this pull request Nov 20, 2020
6 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants