This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix and add benchs for democracy pallet #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gui1117
commented
May 5, 2020
gui1117
commented
- external propose now consider the cost of a blacklist with multiple vetoers
- add a benchmark for on_initialize when nothing happens (no maturing referenda nor launch)
gui1117
added
B0-silent
shawntabrizi
approved these changes
May 6, 2020
kianenigma
reviewed
May 6, 2020
| @@ -467,6 +471,36 @@ benchmarks! { | |||
| } | |||
| } | |||
|
|
|||
| on_initialize_no_launch_no_maturing { | |||
There was a problem hiding this comment.
how is this different from all the other on_initialize_xxx benches?
There was a problem hiding this comment.
yes on_initialize_external do benchmark the launch of an external referendum and the maturing of R referendums.
and on_initialize_public does same with public referendum.
I agree doc should improve here, I'll try to do in my weight PR
kianenigma
approved these changes
May 6, 2020
apopiak
reviewed
May 6, 2020
Co-authored-by: Alexander Popiak <[email protected]>
gui1117
added
A8-mergeoncegreen
and removed
A0-please_review
This reverts commit 0123311.
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.