This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Setting versions locally towards 2.0 release #4404
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f7ce4ee
clean up cargo.toml syntax
gnunicorn 62263dc
bumping versions to 2.0
gnunicorn 8bb1d1a
bump networking to 0.8
gnunicorn c84257f
move consensus down to 0.8
gnunicorn c988b68
bump consensus pallets to 0.8.0, too
gnunicorn bbd725b
Upping babe and aura pallets
gnunicorn dde39ba
add remaining, missing version definitions
gnunicorn faad231
Master.into()
gnunicorn ec7022f
missed some
gnunicorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,11 @@ authors = ["Parity Technologies <[email protected]>"] | |
| edition = "2018" | ||
|
|
||
| [dependencies] | ||
| sp-core = { path = "../../../primitives/core", default-features = false } | ||
| sp-runtime = { path = "../../../primitives/runtime", default-features = false } | ||
| sp-core = { version = "2.0.0", default-features = false, path = "../../../primitives/core" } | ||
| sp-runtime = { version = "2.0.0", default-features = false, path = "../../../primitives/runtime" } | ||
|
|
||
| [dev-dependencies] | ||
| sp-serializer = { path = "../../../primitives/serializer" } | ||
| sp-serializer = { version = "2.0.0", path = "../../../primitives/serializer" } | ||
| pretty_assertions = "0.6.1" | ||
|
|
||
| [features] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why set versions as well as path? it's just redundant additional tedious data to maintain isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, defining the version is a requirement to publish on
crates.io. Cargo doesn't have anypublish --alland won't resolve path to figure out which version to use–in general its publishing helper for workspaces are pretty rudimentary. On the other sidepathis obviously a lot easier and nicer for development.Fortunately, because cargo uses semver this isn't much of a deal. We can just define
version = "2.0.0"and even if we bump the minor or patch version of that crate to make a new release, this doesn't need any update on this crate. Cargo just will figure out the best version oncargo update(orcargo buildif first time). Our internalCargo.lockwill also update without problems. This also allows us to do version updates more independently per crate, like updating network and consensus and apply the changes to the crates that follow without having to publish a breaking change on these, if those dependencies don't alter their externally perceived API.Having both is the common way to stay sane, and is what we do in the libp2p workspace repo and common practice on other workspace repos, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍