-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[fix lint warnings: Uniques pallet] fix clippy::doc_markdown warnings #14592
Conversation
bot bench $ pallet dev pallet_uniques Actually running the benches should also fix it - and tell us if my fix was good 😄 |
@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3204420 was started for your command Comment |
@ggwpez Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sacha-l can you please run the linter again?
The weights got updated by the bot now.
Ran it locally - there's still some warnings: warning: item in documentation is missing backticks
--> frame/uniques/src/weights.rs:18:31
|
18 | //! Autogenerated weights for pallet_uniques
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: requested on the command line with `-W clippy::doc-markdown`
help: try
|
18 | //! Autogenerated weights for `pallet_uniques`
| ~~~~~~~~~~~~~~~~
warning: backticks are unbalanced
--> frame/uniques/src/weights.rs:20:1
|
20 | / //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
21 | | //! DATE: 2023-07-17, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
22 | | //! WORST CASE MAP SIZE: `1000000`
23 | | //! HOSTNAME: `runner-gghbxkbs-project-145-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
24 | | //! EXECUTION: ``, WASM-EXECUTION: `Compiled`, CHAIN: `Some("dev")`, DB CACHE: `1024`
| |_____________________________________________________________________________________^
|
= help: a backtick may be missing a pair
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
warning: item in documentation is missing backticks
--> frame/uniques/src/weights.rs:50:33
|
50 | /// Weight functions needed for pallet_uniques.
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
50 | /// Weight functions needed for `pallet_uniques`.
| ~~~~~~~~~~~~~~~~
warning: item in documentation is missing backticks
--> frame/uniques/src/weights.rs:80:17
|
80 | /// Weights for pallet_uniques using the Substrate node and recommended hardware.
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
80 | /// Weights for `pallet_uniques` using the Substrate node and recommended hardware.
| ~~~~~~~~~~~~~~~~
warning: `pallet-uniques` (lib) generated 4 warnings (run `cargo clippy --fix --lib -p pallet-uniques` to apply 3 suggestions) |
What command are you running? |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Yes - shouldn't we update the template with the missing backticks? |
bot bench $ pallet dev pallet_uniques |
@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3223649 was started for your command Comment |
@ggwpez Command |
bot merge |
This PR fixes the 481 warnings emitted by the
doc_markdown
lint for the Uniques pallet.Note: These lint warnings should no longer happen for newly generated weight files thanks to #14535.
This is part of an ongoing effort from the https://github.com/orgs/paritytech/teams/devrel team to improve developer experience.