Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

improve pallet hooks docs #14578

Merged
merged 15 commits into from
Jul 17, 2023
Merged

improve pallet hooks docs #14578

merged 15 commits into from
Jul 17, 2023

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Jul 14, 2023 •
edited
Loading

subset of #14279, making it ready earlier for PBA.
Companion to #13987

@liamaharon possibly you want to add more about migrations?

Screenshot 2023-07-17 at 11 47 02

@kianenigma kianenigma added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jul 14, 2023
@kianenigma kianenigma requested review from a team July 14, 2023 12:45
This was referenced Jul 15, 2023
Closed
Closed
sam0x17
sam0x17 approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, one that was substantive

@kianenigma kianenigma requested review from ggwpez and gupnik July 17, 2023 06:58
@kianenigma
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 17, 2023 •
edited
Loading

@kianenigma https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3197965 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-de4f8105-0413-4d60-8b66-13a6b672726e to cancel this command or bot cancel to cancel all commands in this pull request.

@kianenigma
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@command-bot
Copy link

command-bot bot commented Jul 17, 2023

@kianenigma Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3197965 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3197965/artifacts/download.

gui1117
gui1117 reviewed Jul 17, 2023
View reviewed changes
juangirini
juangirini approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

gpestana
gpestana approved these changes Jul 17, 2023
View reviewed changes
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit f9e67cd into master Jul 17, 2023
@paritytech-processbot paritytech-processbot bot deleted the kiz-improve-hooks-docs branch July 17, 2023 10:37
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@kianenigma @sam0x17
@juangirini @nathanwhit
improve pallet hooks docs (paritytech#14578)
9858181 
* improve pallet hooks docs

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* fix mastekn removal

* Apply suggestions from code review

Co-authored-by: Juan <[email protected]>

* add diagram

* fix all links

* fix diagram

* improve diagram with some notes

* update

---------

Co-authored-by: Sam Johnson <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: Juan <[email protected]>
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
@kianenigma @sam0x17
@juangirini @Ank4n
improve pallet hooks docs (#14578)
d65b572 
* improve pallet hooks docs

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Sam Johnson <[email protected]>

* fix mastekn removal

* Apply suggestions from code review

Co-authored-by: Juan <[email protected]>

* add diagram

* fix all links

* fix diagram

* improve diagram with some notes

* update

---------

Co-authored-by: Sam Johnson <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: Juan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 left review comments

@gpestana gpestana gpestana approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@juangirini juangirini juangirini approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

@gupnik gupnik Awaiting requested review from gupnik

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kianenigma @gpestana @sam0x17 @juangirini @gui1117