This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-cli: Remove SubstrateCli::native_runtime_version function
#14511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native runtime will be removed in the near future and thus this function will not be required anymore. \# Code changes Downstream users just need to remove `native_runtime_version` from their implementation of the `SubstrateCli` trait.
bkchr
added
A0-please_review
michalkucharczyk
approved these changes
Jul 4, 2023
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Jul 4, 2023
bkchr
added a commit
to paritytech/cumulus
that referenced
this pull request
Jul 4, 2023
cheme
approved these changes
Jul 5, 2023
koute
approved these changes
Jul 5, 2023
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#7459 |
|
bot merge |
|
Error: Statuses failed for 76c2082 |
|
bot merge force |
paritytech-processbot bot
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Jul 5, 2023
* Companion for Substrate#14511 paritytech/substrate#14511 * Make benchmarking build without any native runtime * Fix warning * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
Jul 5, 2023
* Companion for Substrate#14511 paritytech/substrate#14511 * update lockfile for {"substrate", "polkadot"} --------- Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion for Substrate#14511 paritytech/substrate#14511 * update lockfile for {"substrate", "polkadot"} --------- Co-authored-by: parity-processbot <>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ytech#14511) The native runtime will be removed in the near future and thus this function will not be required anymore. \# Code changes Downstream users just need to remove `native_runtime_version` from their implementation of the `SubstrateCli` trait.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native runtime will be removed in the near future and thus this function will not be required anymore.
Code changes
Downstream users just need to remove
native_runtime_versionfrom their implementation of theSubstrateClitrait.polkadot companion: paritytech/polkadot#7459
cumulus companion: paritytech/cumulus#2821