Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[minor] Fix misleading comment in Notifications #14239

Merged
merged 1 commit into from
May 29, 2023
Merged

[minor] Fix misleading comment in Notifications #14239

merged 1 commit into from
May 29, 2023

Conversation

dmitry-markin
Copy link
Contributor

Resolves #14225.

@dmitry-markin dmitry-markin added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 26, 2023
@dmitry-markin dmitry-markin requested a review from a team May 26, 2023 14:31
altonen
altonen approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@altonen altonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why D2-notlive?

@altonen altonen requested a review from a team May 26, 2023 14:41
@dmitry-markin dmitry-markin added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 26, 2023
@dmitry-markin
Copy link
Contributor Author

Why D2-notlive?

I meant that this is not a live code, just a comment. But the label description does not fit this case, so changed to D3-trivial.

melekes
melekes approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitry-markin dmitry-markin merged commit 84bbb76 into master May 29, 2023
@dmitry-markin dmitry-markin deleted the dm-fix-misleading-comment branch May 29, 2023 10:16
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@dmitry-markin @nathanwhit
minor: fix misleading comment in Notifications (paritytech#14239)
d055db2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@melekes melekes melekes approved these changes

@altonen altonen altonen approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible state inconsistency between Notifications and ProtocolController when incoming connection is dropped
3 participants
@dmitry-markin @melekes @altonen