Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix warp sync #12281

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix warp sync #12281

merged 1 commit into from
Sep 16, 2022

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Sep 15, 2022

Fixes #12268

@arkpar arkpar added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 15, 2022
@arkpar arkpar requested a review from bkchr September 15, 2022 15:54
@arkpar arkpar requested a review from cheme September 16, 2022 13:54
cheme
cheme approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method skip_execution_checks could be do_execution_checks since we always negate it.
But at the same time skip_execution_checks sounds like a better semantic (this being an exception). So may not be a good change

@arkpar
Copy link
Member Author

arkpar commented Sep 16, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7202ca6 into master Sep 16, 2022
@paritytech-processbot paritytech-processbot bot deleted the a-fix-warp-sync branch September 16, 2022 14:16
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@arkpar @ark0f
Fix warp sync (paritytech#12281)
80a8a5b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cheme cheme cheme approved these changes

@bkchr bkchr bkchr approved these changes

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warp sync stuck at downloading block #1 with Verification failed messages
3 participants
@arkpar @cheme @bkchr