Copy weight files into node-template

[tifecool]

PR attempts to solve issue #11090

Copied weight files and TOML from support.

polkadot address: 1s51dYXziQwTnSnModErKfra3TeEsVipqzY846CLCTEXtHJ

[ggwpez]

Thanks for the help!
You still need to use the weights, as currently the node is still using the weights from frame_support.
I did not mark this issue as "mentor" since there is more involved to what I read and it was more of a reminder for me.

Could you please rename the package to node-template-runtime-constants and move it to a constants dir? As more constants will be added there analogous to Polkadot. The structure should look exactly as in Polkadot.

[tifecool]

I'm on it. Sorry about the late response.

[ggwpez]

That one point is still outstanding:

You still need to use the weights, as currently the node is still using the weights from frame_support.

I think we can also merge as-is and then I do that together with an update of the weights.
PS: The CI should be fixed when you merge master into your branch.

[tifecool]

I think we can also merge as-is and then I do that together with an update of the weights.

I'd like this. Not sure I fully understand the code so well and would love to be involved 🙏

[shawntabrizi]

/tip small

[substrate-tip-bot]

Please fix the following problems before calling the tip bot again:

• Contributor did not properly post their Polkadot or Kusama address. Make sure the pull request has: "{network} address: {address}".

[shawntabrizi]

@tifecool if you would like a small tip in KSM or DOT, please include your address in the PR description

[tifecool]

@tifecool if you would like a small tip in KSM or DOT, please include your address in the PR description

done ❤️

[shawntabrizi]

/tip small

[substrate-tip-bot]

A small tip was successfully submitted for tifecool (1s51dYXziQwTnSnModErKfra3TeEsVipqzY846CLCTEXtHJ on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

[ggwpez]

I thought about this again and think that it is better to not create a new crate, since we somehow need to keep the balance between completeness and understandability.
On the one hand it should be a complete example but on the other hand a new user should have a chance at understanding it.
So in the current state the weights are in their own folder besides the runtime lib.rs.

[tifecool]

I thought about this again and think that it is better to not create a new crate, since we somehow need to keep the balance between completeness and understandability. On the one hand it should be a complete example but on the other hand a new user should have a chance at understanding it. So in the current state the weights are in their own folder besides the runtime lib.rs.

So how should we implement it instead?

[shawntabrizi]

Id rather we dont have this re-export for clarity where things are coming from

[tifecool]

Maybe we could rename the weights.rs to template_weights.rs instead? @ggwpez

[shawntabrizi]

In general I don't think the node-template needs custom weight stuff. It adds quite a bit of complexity, and doesn't really make sense since users are likely to change the node template right away, and thus invalidate the weights.

Probably best to just get the default weights from the main substrate node at this time.