This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pallet-referenda: make the pallet instantiable #11089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koushiro <[email protected]>
koushiro
changed the title
shawntabrizi
added
B0-silent
Comment on lines
+87
to
+88
| use self::branch::{BeginDecidingBranch, OneFewerDecidingBranch, ServiceBranch}; | ||
| pub use self::{ |
There was a problem hiding this comment.
Adding self or crate makes it easier to distinguish module name from external crate name, I think
shawntabrizi
approved these changes
Mar 22, 2022
|
delivered a tip in the conviction-voting pr |
ggwpez
approved these changes
Mar 24, 2022
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
Signed-off-by: koushiro <[email protected]>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
Signed-off-by: koushiro <[email protected]>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
Signed-off-by: koushiro <[email protected]>
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
Signed-off-by: koushiro <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Signed-off-by: koushiro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro [email protected]
related issue: #11056
polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK