This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
pallet_assets : Remove event for no_op #11023
Merged
paritytech-processbot
merged 4 commits into
paritytech:master
from
stanly-johnson:stanly_remove_noop_event
Apr 14, 2022
Merged
pallet_assets : Remove event for no_op #11023
paritytech-processbot
merged 4 commits into
paritytech:master
from
stanly-johnson:stanly_remove_noop_event
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Mar 13, 2022
shawntabrizi
approved these changes
Mar 13, 2022
ggwpez
approved these changes
Mar 14, 2022
ggwpez
reviewed
Mar 14, 2022
Please consider to pull latest |
bot rebase |
Rebasing |
… stanly_remove_noop_event
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Checks failed for fdc3f38 |
bot merge |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* remove no_op event * ensure no transferred event emitted Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* remove no_op event * ensure no transferred event emitted Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes emiting an event for no_op in pallet-assets
resolves #10927