Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet_assets : Remove event for no_op #11023

Conversation

stanly-johnson
Copy link
Contributor

Removes emiting an event for no_op in pallet-assets

resolves #10927

@bkchr bkchr requested a review from ggwpez March 13, 2022 19:17
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 13, 2022
@sergejparity
Copy link
Contributor

Please consider to pull latest master into your branch to fix GHA Check labels failure. Location of CI scripts has changed in #11008

@ggwpez
Copy link
Member

ggwpez commented Mar 14, 2022

bot rebase

@paritytech-processbot
Copy link

Rebasing

@stale
Copy link

stale bot commented Apr 14, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Apr 14, 2022
@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Apr 14, 2022
@ggwpez
Copy link
Member

ggwpez commented Apr 14, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for fdc3f38

@ggwpez
Copy link
Member

ggwpez commented Apr 14, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c4f3d02 into paritytech:master Apr 14, 2022
@stanly-johnson stanly-johnson deleted the stanly_remove_noop_event branch April 14, 2022 19:42
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* remove no_op event

* ensure no transferred event emitted

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* remove no_op event

* ensure no transferred event emitted

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pallet_assets : event emitted for noop
5 participants