Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Bump tokio to 1.17.0 #10894

Merged
merged 5 commits into from
Mar 28, 2022
Merged

Bump tokio to 1.17.0 #10894

merged 5 commits into from
Mar 28, 2022

Conversation

koute
Copy link
Contributor

@koute koute commented Feb 21, 2022 •
edited
Loading

polkadot companion: paritytech/polkadot#4965

cumulus companion: paritytech/cumulus#1014

The newest version of tokio apparently has some potentially significant performance improvements. (changelog here)

@koute koute added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 21, 2022
@koute koute requested a review from a team February 21, 2022 11:35
@koute koute requested a review from andresilva as a code owner February 21, 2022 11:35
@ggwpez
Copy link
Member

ggwpez commented Feb 21, 2022

Looks like you also need to update it for Polkadot since the versions are incompatible?

@niklasad1 niklasad1 changed the title Bump tokio to 0.17.0 Bump tokio to 1.17.0 Feb 21, 2022
@wigy-opensource-developer
Copy link
Contributor

Just mentioning here that libp2p still uses tokio 1.15

@bkchr
Copy link
Member

bkchr commented Feb 21, 2022

Just mentioning here that libp2p still uses tokio 1.15

This is not true? 1.17.0 is used everywhere in Substrate. 1.15.0 is also semver compatible to 1.17.0.

@wigy-opensource-developer
Copy link
Contributor

Yeah, right. I think I still cached 0.17 that was in the issue title in my head, sorry. 🥲

@koute koute mentioned this pull request Feb 22, 2022
Merged
@koute
Copy link
Contributor Author

koute commented Feb 22, 2022 •
edited
Loading

Oops, sorry, yeah, I brainfarted and put 0.17.0 in the commit message/branch name since I'm so used to everything in the ecosystem being on the 0th version. (:

@KiChjang
Copy link
Contributor

It now seems to also need a PR to cumulus as well, bumping tokio to version 1.17.

@koute koute mentioned this pull request Feb 22, 2022
Merged
@stale
Copy link

stale bot commented Mar 27, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 27, 2022
@bkchr
Copy link
Member

bkchr commented Mar 27, 2022

@koute this requires some master merge

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 27, 2022
@bkchr bkchr merged commit a5f3dbe into paritytech:master Mar 28, 2022
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@koute @KiChjang @DaviRain-Su
Bump tokio to 1.17.0 (paritytech#10894)
2720ef5 
* Bump `tokio` to 0.17.0

* Revert version changes to scale-info

Co-authored-by: Keith Yeung <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@koute @KiChjang @ark0f
Bump tokio to 1.17.0 (paritytech#10894)
0537772 
* Bump `tokio` to 0.17.0

* Revert version changes to scale-info

Co-authored-by: Keith Yeung <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang left review comments

@wigy-opensource-developer wigy-opensource-developer wigy-opensource-developer approved these changes

@bkchr bkchr bkchr approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koute @ggwpez @wigy-opensource-developer @bkchr @KiChjang