Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make approvers team a link in messages, to ensure better UX #167

Closed
shawntabrizi opened this issue Aug 27, 2024 · 2 comments · Fixed by #180
Closed

Make approvers team a link in messages, to ensure better UX #167

shawntabrizi opened this issue Aug 27, 2024 · 2 comments · Fixed by #180

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented Aug 27, 2024 •
edited
Loading

There is no repo paritytech/tip-bot-approvers, so this warning / message is out of date and should be updated.

image
@mutantcornholio
Copy link
Contributor

It's not a repo, it's a team: https://github.com/orgs/paritytech/teams/tip-bot-approvers.
Any suggestions how to make it more obvious? We can use a link, for example

@shawntabrizi
Copy link
Member Author

shawntabrizi commented Aug 27, 2024 •
edited
Loading

yeah turning the text into a clickable link would be good. perhaps also changing the link to match the format of the URL

I think that would resolve this issue

@mutantcornholio mutantcornholio changed the title Bot says approvers are found in paritytech/tip-bot-approvers Make approvers team a link in messages, to ensure better UX Sep 18, 2024
mutantcornholio added a commit that referenced this issue Sep 19, 2024
@mutantcornholio
Using an org link for "only members of..." comment
c3093db 
Not everyone recognizes that paritytech/tip-bot-approvers is actually a
team, not a repo. Using a link might clarify it.

Fixes #167
@mutantcornholio mutantcornholio mentioned this issue Sep 19, 2024
Merged
mutantcornholio added a commit that referenced this issue Sep 20, 2024
@mutantcornholio
Using an org link for "only members of..." comment
7a2e218 
Not everyone recognizes that paritytech/tip-bot-approvers is actually a
team, not a repo. Using a link might clarify it.

Fixes #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using an org link for "only members of..." comment paritytech/substrate-tip-bot
2 participants
@mutantcornholio @shawntabrizi