Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new implementation names #251

Merged
merged 1 commit into from
Apr 15, 2020
Merged

add new implementation names #251

merged 1 commit into from
Apr 15, 2020

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Apr 14, 2020 •
edited
Loading

These were recently renamed in paritytech/substrate#5271 paritytech/polkadot#935.

@andresilva andresilva requested a review from maciejhirsz April 14, 2020 18:55
jacogr
jacogr approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as adjusted. Should get rid of the "?" on telemetry.

@maciejhirsz maciejhirsz merged commit 5a6f89c into master Apr 15, 2020
@maciejhirsz maciejhirsz deleted the andre/fix-impl-name branch April 15, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacogr jacogr jacogr approved these changes

@maciejhirsz maciejhirsz maciejhirsz approved these changes

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresilva @maciejhirsz @jacogr