Set up type definitions for the sync state #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
suggested changes
Oct 14, 2020
src/chain_spec/light_sync_state.rs
Outdated
| use super::structs::StorageData; | ||
| use crate::header::{BabeAuthority, BabeNextConfig, GrandpaAuthority}; | ||
| use parity_scale_codec::*; | ||
| use primitive_types::H256; |
There was a problem hiding this comment.
Please use [u8; 32] everywhere instead of H256
src/header/grandpa.rs
Outdated
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] | ||
| #[derive( | ||
| Debug, Copy, Clone, PartialEq, Eq, parity_scale_codec::Encode, parity_scale_codec::Decode, | ||
| )] | ||
| pub struct GrandpaAuthority { |
There was a problem hiding this comment.
I don't want to derive Encode and Decode.
Please copy-paste the definition of GrandpaAuthority in light_sync_state.rs if you need these traits.
src/header/babe.rs
Outdated
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] | ||
| #[derive( | ||
| Debug, Copy, Clone, PartialEq, Eq, parity_scale_codec::Encode, parity_scale_codec::Decode, | ||
| )] | ||
| pub struct BabeAuthority { |
src/chain_spec/light_sync_state.rs
Outdated
| #[derive(Debug, Decode, Encode)] | ||
| pub(super) struct EpochChanges { | ||
| inner: ForkTree<PersistedEpochHeader>, | ||
| epochs: std::collections::BTreeMap<(H256, u32), PersistedEpoch>, |
There was a problem hiding this comment.
Should be alloc::collections::BTreeMap, and imported on top of the file.
src/chain_spec/light_sync_state.rs
Outdated
| @@ -0,0 +1,115 @@ | |||
| use super::structs::StorageData; | |||
tomaka
approved these changes
Oct 14, 2020
|
I think it'd be better to wait until paritytech/substrate#7225 gets merged. |
tomaka
suggested changes
Oct 14, 2020
src/chain_spec/light_sync_state.rs
Outdated
Comment on lines
1
to
15
| // Copyright 2017-2020 Parity Technologies (UK) Ltd. | ||
| // This file is part of Substrate. | ||
|
|
||
| // Substrate is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Substrate is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Substrate. If not, see <http://www.gnu.org/licenses/>. |
There was a problem hiding this comment.
Substrate-lite has a different header. It is literally in every file!
There was a problem hiding this comment.
Apart from the file I copied it from 😉
tomaka
approved these changes
Oct 14, 2020
|
This can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up all the type definitions needed to decode the sync states from paritytech/substrate#7225. This doesn't set up anything to load the sync state into the chain infomation yet. For testing, you can use this chain spec: https://github.com/paritytech/substrate/blob/a9b22d4e901c2633f92fefc6cbfbf1d3a9971ecc/bin/node/cli/res/flaming-fir.json