Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-context: remove dead code #247

Merged
merged 3 commits into from
Feb 28, 2025
Merged

llvm-context: remove dead code #247

merged 3 commits into from
Feb 28, 2025

Conversation

xermicus
Copy link
Member

  • remove the __sha3 function symbol: this is provided by the pallet
  • remove the storage address spaces: they are not mapped into memory

@xermicus
remove the __sha3 function symbol
787d3c8 
Signed-off-by: Cyrill Leutwiler <[email protected]>
@xermicus
remove the storage address space
f93c38d 
Signed-off-by: Cyrill Leutwiler <[email protected]>
@athei
Copy link
Member

athei commented Feb 28, 2025

Lets' please merge #248 first and then rebase this one. Otherwise I need to re-run the expensive llvm-builder test again.

@xermicus
Copy link
Member Author

Sure no problem

@xermicus xermicus merged commit 77e0344 into main Feb 28, 2025
10 checks passed
@xermicus xermicus deleted the cl/various branch February 28, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xermicus @athei