Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #230

Merged
merged 55 commits into from
Feb 25, 2025
Merged

CI improvements #230

merged 55 commits into from
Feb 25, 2025

Conversation

AndWeHaveAPlan
Copy link
Contributor

@AndWeHaveAPlan AndWeHaveAPlan commented Feb 24, 2025

  • llvm artifacts search, download and extract now in get-llvm action
  • get-emsdk action - clone, install, activate emsdk, so we don't need to build revive-builder for this
  • switch workflows to new actions
  • concurrency for remaining workflows (cancel run if new run is triggered)
  • target_commitish for main release, fixes release commit
  • Run release workflow in PR without creating a release if PR is labeled with release-test

@AndWeHaveAPlan
Copy link
Contributor Author

@AndWeHaveAPlan AndWeHaveAPlan marked this pull request as ready for review February 24, 2025 11:17
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-24 at 17 43 19

Can't mark the line in the script. But this isn't correct, right? This should be expanded to the actual arch? In the script it uses " which might cause this?

Another question: The release-test lable only does something in case you actually also bump the version side the PR, right?

@AndWeHaveAPlan
Copy link
Contributor Author

AndWeHaveAPlan commented Feb 24, 2025

Can't mark the line in the script. But this isn't correct, right? This should be expanded to the actual arch? In the script it uses " which might cause this?

Its because the job is skipped, so gh does not resolve matrix
Just removed arch part, as gh automatically expand this on job run, like for test-revive-wasm (*)

Another question: The release-test lable only does something in case you actually also bump the version side the PR, right?

Yes, for PR's workflow will run like a real release, except for the creation part

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's have @xermicus have a look before merging.

Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xermicus xermicus merged commit 7ffe64e into paritytech:main Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants