This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add check for locked zero on locked value in pallet-xcm
#7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
reviewed
May 12, 2023
vstam1
added
A0-please_review
KiChjang
added
B0-silent
KiChjang
approved these changes
May 12, 2023
|
Gets fixed by paritytech/substrate#14144 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
set_lockfunction is not working when thelockedamount is 0 and we use the implementation of the balances pallet as theset_lockimplementation of the balances pallet is no-op when the locked amount is 0. So we remove the lock if thelockedvalue is 0, meaning that there is no lock anymore in the LockedFungibles storage for this sovereign_account.