This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make rolling session more resilient in case of long finality stalls #6106
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
e488f52
Impl dynamic window size. Keep sessions for unfinalized chain
sandreim 5780cc9
feedback
sandreim 2132d9c
Stretch also in contructor plus tests
sandreim eb06959
review feedback
sandreim 88ac66f
fix approval-voting tests
sandreim a7d97d0
grunting: dispute coordinator tests
sandreim 3e4d9d5
add session window column
sandreim 810c4d6
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
sandreim 1732baa
integrate approval vote and fix tests
sandreim c9045cd
fix rolling session tests
sandreim 781ef47
Small refactor
sandreim 89d4d00
WIP, tests failing
sandreim 09d25e6
Fix approval voting tests
sandreim 6ea92ed
fix dispute-coordinator tests
sandreim cecd5e0
remove uneeded param
sandreim e0aee8b
fmt
sandreim c6e727d
fix loose ends
sandreim 90cdad7
allow failure and tests for it
sandreim 1ae389b
fix comment
sandreim ee093f8
comment fix
sandreim 5ccc675
style fix
sandreim 762be95
new col doesn't need to be ordered
sandreim f6d37a9
fmt and spellcheck
sandreim 8de8d66
db persist tests
sandreim 5c41d35
Add v2 config and cols
sandreim 11fb825
DB upgrade WIP
sandreim 0a2ecd6
Fix comments
sandreim c887eca
add todo
sandreim 32947c9
update to parity-db to "0.4.2"
sandreim 3d75b69
migration complete
sandreim a17770d
One session window size
sandreim 93b5943
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
sandreim f91681c
fix merge damage
sandreim 5a5e7c6
fix build errors
sandreim cf05ac6
fmt
sandreim dcb31c9
comment fix
sandreim 47765bc
fix build
sandreim 81d7e05
make error more explicit
sandreim 516f23e
add comment
sandreim 0b4bf94
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
sandreim 316f5ed
refactor conflict merge
sandreim 3b45f23
rename col_data
sandreim 8305677
add doc comment
sandreim f8b6023
fix build
sandreim 43e1823
migration: move all cols to v2
sandreim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add comment
Signed-off-by: Andrei Sandu <[email protected]>
- Loading branch information
commit 516f23efe38b8d985ec6808be5f76cf3f512c7b7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be removed soon, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this will be in a separate PR, we'll use a dynamic window size - up to the last finalized block session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also means opportunity to delete code and simplify