Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change validation & collation protocol names to include genesis hash & fork id #5876

Merged
merged 13 commits into from
Aug 30, 2022
Merged

Change validation & collation protocol names to include genesis hash & fork id #5876

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
14ba0c9
Change validation & collation protocol names to include genesis hash …
dmitry-markin Aug 12, 2022
ec48b1c
Add tests for `PeerSetProtocolNames`
dmitry-markin Aug 13, 2022
cdc57cd
Update legacy protocol name constants
dmitry-markin Aug 18, 2022
beb22c4
Update legacy protocol name constants (part 2)
dmitry-markin Aug 18, 2022
e67ce6b
minor: fix docs
dmitry-markin Aug 18, 2022
0ec120b
Lookup protocol names in a map instead of generating them every time
dmitry-markin Aug 19, 2022
09af74c
Add tests for protocol versions registration
dmitry-markin Aug 19, 2022
5525244
WIP: make ProtocolVersion a strongly typed struct
dmitry-markin Aug 22, 2022
a9091a0
Make ProtocolVersion a strongly typed struct (part 2)
dmitry-markin Aug 23, 2022
93ae936
minor: expect wording
dmitry-markin Aug 23, 2022
894467f
Merge branch 'master' into dm-notification-protocol-names
dmitry-markin Aug 23, 2022
197129c
PR review fix
dmitry-markin Aug 29, 2022
4114d0f
minor: use `Display` instead of `Debug` for `ProtocolVersion` tracing
dmitry-markin Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update legacy protocol name constants 
Co-authored-by: Bastian Köcher <[email protected]>
  • Loading branch information
@dmitry-markin @bkchr
dmitry-markin and bkchr authored Aug 18, 2022
commit cdc57cd3fd9e64fa2bbe1a78f491c290ebf182b7
4 changes: 2 additions & 2 deletions node/network/protocol/src/peer_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ use std::{
use strum::{EnumIter, IntoEnumIterator};

// Only supported protocol versions should be defined here.
const VALIDATION_PROTOCOL_V1: &str = "/polkadot/validation/1";
const COLLATION_PROTOCOL_V1: &str = "/polkadot/collation/1";
const LEGACY_VALIDATION_PROTOCOL_V1: &str = "/polkadot/validation/1";
const LEGACY_COLLATION_PROTOCOL_V1: &str = "/polkadot/collation/1";

/// The main protocol version, currently the same for validation & collation.
const MAIN_PROTOCOL_VERSION: ProtocolVersion = 1;
Expand Down