This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
gate approval-checking logic #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A2-insubstantial
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
ordian
approved these changes
Feb 18, 2021
rphmeier
added a commit
that referenced
this pull request
Feb 18, 2021
bkchr
pushed a commit
that referenced
this pull request
Feb 19, 2021
ghost
pushed a commit
that referenced
this pull request
May 3, 2021
* Update branch * Make it compile * Compile * gate approval-checking logic (#2470) * Fix build * Updates * Fix merge * Adds missing crate * Companion for Substrate#8386 paritytech/substrate#8386 * Fix fix fix * Fix * Fix compilation * Rewrite to `ParachainsInherentDataProvider` * Make it compile * Renamings * Revert stuff * Remove stale file * Guide updates * Update node/core/parachains-inherent/src/lib.rs Co-authored-by: Andronik Ordian <[email protected]> * Update node/core/parachains-inherent/src/lib.rs Co-authored-by: Andronik Ordian <[email protected]> * Apply suggestions from code review * Reset accidental changes * More * Remove stale file * update Substrate Co-authored-by: Robert Habermeier <[email protected]> Co-authored-by: Andronik Ordian <[email protected]> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature-gates all code for approval checking behind an
approval-checkingfeature.