Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Commit

Permalink
Use SIGTERM instead of SIGKILL on PVF worker version mismatch (#6981
Browse files Browse the repository at this point in the history
)
  • Loading branch information
s0me0ne-unkn0wn authored and coderobe committed Apr 4, 2023
1 parent 271b10d commit cafa423
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions node/core/pvf/src/worker_common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ pub async fn framed_recv(r: &mut (impl AsyncRead + Unpin)) -> io::Result<Vec<u8>
Ok(buf)
}

/// In case of node and worker version mismatch (as a result of in-place upgrade), send `SIGKILL`
/// In case of node and worker version mismatch (as a result of in-place upgrade), send `SIGTERM`
/// to the node to tear it down and prevent it from raising disputes on valid candidates. Node
/// restart should be handled by the node owner. As node exits, unix sockets opened to workers
/// get closed by the OS and other workers receive error on socket read and also exit. Preparation
Expand All @@ -428,7 +428,7 @@ pub(crate) fn kill_parent_node_in_emergency() {
// some corner cases, which is checked. `kill()` never fails.
let ppid = libc::getppid();
if ppid > 1 {
libc::kill(ppid, libc::SIGKILL);
libc::kill(ppid, libc::SIGTERM);
}
}
}

0 comments on commit cafa423

Please sign in to comment.