Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serialize & Deserialize to umbrella crate derive module #7764

Merged

Conversation

PolkadotDom
Copy link
Contributor

@PolkadotDom PolkadotDom commented Mar 1, 2025

When working with storage types that are to be set in the genesis block, deriving serde::Serialize & serde::Deserialize is necessary (to my knowledge). This PR introduces Serialize and Deserialize into the umbrella crate derive (and indirectly prelude) module, allowing for similar access as the other storage value derives.

@PolkadotDom PolkadotDom requested a review from a team as a code owner March 1, 2025 18:36
@bkchr bkchr added the T17-primitives Changes to primitives that are not covered by any other label. label Mar 3, 2025
@ggwpez ggwpez enabled auto-merge March 3, 2025 20:18
Copy link
Contributor

@pandres95 pandres95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these traits be gated behind the serde feature, since they're only being used when a project specifically needs serde capabilities?

@ggwpez ggwpez added this pull request to the merge queue Mar 3, 2025
Merged via the queue into paritytech:master with commit 9d9ae34 Mar 3, 2025
248 of 254 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants