-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serialize & Deserialize to umbrella crate derive module #7764
Merged
ggwpez
merged 13 commits into
paritytech:master
from
PolkadotDom:dom/add-serialize-deserialize-to-derive
Mar 3, 2025
Merged
Add Serialize & Deserialize to umbrella crate derive module #7764
ggwpez
merged 13 commits into
paritytech:master
from
PolkadotDom:dom/add-serialize-deserialize-to-derive
Mar 3, 2025
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Mar 2, 2025
ggwpez
approved these changes
Mar 3, 2025
pandres95
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these traits be gated behind the serde
feature, since they're only being used when a project specifically needs serde
capabilities?
bkchr
reviewed
Mar 3, 2025
Merged
via the queue into
paritytech:master
with commit Mar 3, 2025
9d9ae34
248 of 254 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with storage types that are to be set in the genesis block, deriving serde::Serialize & serde::Deserialize is necessary (to my knowledge). This PR introduces Serialize and Deserialize into the umbrella crate derive (and indirectly prelude) module, allowing for similar access as the other storage value derives.