Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #7437 #7465

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #7437 into stable2407 from serban300.

See the documentation on how to use this bot.

Fixes #7400

(cherry picked from commit d6aa157)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

lexnv
lexnv previously approved these changes Feb 5, 2025
gui1117
gui1117 previously approved these changes Feb 5, 2025
@EgorPopelyaev
Copy link
Contributor

@serban300 Is prdoc needed for this pr?

@serban300
Copy link
Contributor

@serban300 Is prdoc needed for this pr?

@EgorPopelyaev no, I don't think so. We're just removing a structure that is private and unused

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez dismissed stale reviews from gui1117 and lexnv via c331311 February 5, 2025 11:35
@@ -0,0 +1,10 @@
title: Update SCALE codec indices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more exact it is a removal of inner dead code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got confused with the MRs. We need more CI to copy these files...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez so is the prdoc needed ? Even if we're just removing dead code ? If so I can add it to the other backports as well

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@EgorPopelyaev EgorPopelyaev merged commit dc31da0 into stable2407 Feb 5, 2025
94 of 161 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7437-to-stable2407 branch February 5, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants