Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #7446 #7460

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #7446 into stable2407 from serban300.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7446-to-stable2407
git worktree add --checkout .worktree/backport-7446-to-stable2407 backport-7446-to-stable2407
cd .worktree/backport-7446-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 37446fcbb05150cd304fde157f87e9004f203403
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8143590

@serban300 serban300 marked this pull request as ready for review February 5, 2025 09:01
@serban300 serban300 requested a review from a team as a code owner February 5, 2025 09:01
@serban300 serban300 added the R0-silent Changes should not be mentioned in any release notes label Feb 5, 2025
gui1117
gui1117 previously approved these changes Feb 5, 2025
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2025

/cmd prdoc --bump none --audience runtime_dev

ggwpez
ggwpez previously approved these changes Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez dismissed stale reviews from gui1117 and themself via b00aeb9 February 5, 2025 11:30
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2025

Actually if we mark it as bump level none, then it will not publish this version since there is no change. Changing it to patch now.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 5, 2025 11:31
@EgorPopelyaev EgorPopelyaev merged commit 544b535 into stable2407 Feb 5, 2025
132 of 164 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7446-to-stable2407 branch February 5, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants