-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omni-node: Adjust manual seal parameters #7451
Conversation
/cmd prdoc --audience runtime_dev --bump patch |
All GitHub workflows were cancelled due to failure one of the required jobs. |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2407
git worktree add --checkout .worktree/backport-7451-to-stable2407 backport-7451-to-stable2407
cd .worktree/backport-7451-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2409
git worktree add --checkout .worktree/backport-7451-to-stable2409 backport-7451-to-stable2409
cd .worktree/backport-7451-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2412
git worktree add --checkout .worktree/backport-7451-to-stable2412 backport-7451-to-stable2412
cd .worktree/backport-7451-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
Backport #7451 into `stable2412` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Sebastian Kunert <[email protected]>
This PR will make omni-node dev-mode once again compatible with older runtimes.
The changes introduced in #6825 changed constraints that are enforced in the runtime. For normal chains this should work fine, since we have real parameters there, like relay chain slots and parachain slots.
For these manual seal parameters we need to respect the constraints, while faking all the parameters. This PR should fix manual seal in omni-node to work with runtime build before and after #6825 (I tested that).
In the future, we should look into improving the parameterization here, possibly by introducing proper aura pre-digests so that the parachain slot moves forward. This will require quite a bit of refactoring on the manual seal node side however. Issue: #7453
Also, the dev chain spec in parachain template is updated. This makes it work with stable2412-1 and master omni-node. Once the changes here are backported and in a release, all combinations will work again.
fixes #7341