Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omni-node: Adjust manual seal parameters #7451

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 4, 2025

This PR will make omni-node dev-mode once again compatible with older runtimes.

The changes introduced in #6825 changed constraints that are enforced in the runtime. For normal chains this should work fine, since we have real parameters there, like relay chain slots and parachain slots.

For these manual seal parameters we need to respect the constraints, while faking all the parameters. This PR should fix manual seal in omni-node to work with runtime build before and after #6825 (I tested that).

In the future, we should look into improving the parameterization here, possibly by introducing proper aura pre-digests so that the parachain slot moves forward. This will require quite a bit of refactoring on the manual seal node side however. Issue: #7453

Also, the dev chain spec in parachain template is updated. This makes it work with stable2412-1 and master omni-node. Once the changes here are backported and in a release, all combinations will work again.

fixes #7341

@skunert
Copy link
Contributor Author

skunert commented Feb 4, 2025

/cmd prdoc --audience runtime_dev --bump patch

@skunert skunert added the T9-cumulus This PR/Issue is related to cumulus. label Feb 4, 2025
@skunert skunert added the A4-needs-backport Pull request must be backported to all maintained releases. label Feb 4, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13140999658
Failed job name: test-linux-stable

@skunert skunert requested a review from a team February 5, 2025 12:49
@skunert skunert marked this pull request as ready for review February 5, 2025 12:49
@skunert skunert added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 9c474d5 Feb 5, 2025
246 of 313 checks passed
@skunert skunert deleted the skunert/omni-node-fix-manual-seal branch February 5, 2025 15:25
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7451-to-stable2407
git worktree add --checkout .worktree/backport-7451-to-stable2407 backport-7451-to-stable2407
cd .worktree/backport-7451-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7451-to-stable2409
git worktree add --checkout .worktree/backport-7451-to-stable2409 backport-7451-to-stable2409
cd .worktree/backport-7451-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7451-to-stable2412
git worktree add --checkout .worktree/backport-7451-to-stable2412 backport-7451-to-stable2412
cd .worktree/backport-7451-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease

EgorPopelyaev pushed a commit that referenced this pull request Feb 7, 2025
Backport #7451 into `stable2412` from skunert.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Sebastian Kunert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution aborted due to trap: wasm trap: wasm unreachable instruction executed
3 participants