Fixes #219 #7407
Open
Fixes #219 #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Lau <[email protected]>
aurexav
force-pushed
the
dispatch-as-checked
branch
from
c6b8a3b to
98ccdc1
Compare
gui1117
approved these changes
Feb 1, 2025
| @@ -454,6 +454,36 @@ pub mod pallet { | |||
| let res = call.dispatch_bypass_filter(frame_system::RawOrigin::Root.into()); | |||
| res.map(|_| ()).map_err(|e| e.error) | |||
| } | |||
|
|
|||
| /// Dispatches a function call with a provided origin. | |||
| /// Almost the same as [`Pallet::dispatch_as`] but check the result of the call. | |||
There was a problem hiding this comment.
Maybe we can be more explicit and say it will return an error if the call returns an error.
I find the verb "check" a bit vague here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new extrinsic
dispatch_as_checked.It's almost the same as
dispatch_asbut check the result of the call.Closes #219.
And add more unit tests to cover
dispatch_asanddispatch_as_checked.Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y