Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve set_validation_data error message. #7359

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Jan 28, 2025

The old error message was often confusing, because the real reason for the error will be printed during inherent execution.

@skunert skunert added the T9-cumulus This PR/Issue is related to cumulus. label Jan 28, 2025
@skunert skunert requested a review from a team January 28, 2025 11:58
@skunert
Copy link
Contributor Author

skunert commented Jan 28, 2025

/cmd prdoc --bump patch --audience runtime_dev

@michalkucharczyk michalkucharczyk requested a review from a team January 28, 2025 13:16
@skunert skunert enabled auto-merge January 28, 2025 13:33
@skunert skunert added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 29eb533 Jan 28, 2025
204 of 206 checks passed
@skunert skunert deleted the skunert/clarify-inherent-error-message branch January 28, 2025 14:35
ordian added a commit that referenced this pull request Feb 3, 2025
* master:
  Remove warnings by cleaning up the `Cargo.toml` (#7416)
  [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401)
  fix pre-dispatch PoV underweight for ParasInherent (#7378)
  malus-collator: implement malicious collator submitting same collation to all backing groups (#6924)
  `fatxpool`: use tracing for logging (#6897)
  Improvements for Weekly bench (#7390)
  Replace derivative dependency with derive-where (#7324)
  Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379)
  Fix Snowbridge benchmark tests (#7296)
  Bridges small nits/improvements (#7383)
  Migrating cumulus-pallet-session-benchmarking to Benchmarking V2  (#6564)
  [pallet-revive] implement the block author API  (#7198)
  Use checked math in frame-balances named_reserve (#7365)
  move installation of frame-omni-bencher into a cmd.py itself (#7372)
  remove old bench & revert the frame-weight-template (#7362)
  ci: fix workflow permissions (#7366)
  [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338)
  Improve `set_validation_data` error message. (#7359)
  Implement pallet view function queries (#4722)
Ank4n pushed a commit that referenced this pull request Feb 6, 2025
The old error message was often confusing, because the real reason for
the error will be printed during inherent execution.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants