Deprecate HandleLifetime Trait and its Implementations in Favor of Direct frame-system Methods
#7287
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifecool
changed the title
Handlelifetime RemovalHandleLifetime Trait and its Implementations in Favor of Direct frame-system Methods
|
would like to see the CI run @ggwpez |
ggwpez
reviewed
Feb 2, 2025
ggwpez
reviewed
Feb 2, 2025
|
No clue why the CI is not running... maybe rebasing helps. |
|
@ggwpez Disable the new merge experience: |
|
please review @ggwpez |
ggwpez
approved these changes
Feb 8, 2025
| For SelfSufficient (from HandleLifetime): | ||
| Use frame_system::inc_sufficients(t) for the Created method. | ||
| Use frame_system::dec_sufficients(t) for the Killed method. | ||
| These changes align with efforts to reduce abstraction overhead and improve the maintainability of the SDK by leveraging direct frame-system APIs for resource management. |
There was a problem hiding this comment.
Suggested change
| These changes align with efforts to reduce abstraction overhead and improve the maintainability of the SDK by leveraging direct frame-system APIs for resource management. |
Sounds AI generated 😋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7063