Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balances: Configurable Number of Genesis Accounts with Specified Balances for Benchmarking #6267

Merged
merged 38 commits into from
Jan 23, 2025

Conversation

runcomet
Copy link
Contributor

@runcomet runcomet commented Oct 28, 2024

Derived Dev Accounts

Resolves #6040

Description

This update introduces support for creating an arbitrary number of developer accounts at the genesis block based on a specified derivation path.

Key Features

  • Arbitrary Dev Accounts at Genesis: Developers can now specify any number of accounts to be generated at genesis using a hard derivation path.

  • Default Derivation Path: If no derivation path is provided (i.e., when Option<dev_accounts: (..., None)> is set to Some at genesis), the system will default to the path //Sender//{}.

  • No Impact on Total Token Issuance: Developer accounts are excluded from the total issuance of the token supply at genesis, ensuring they do not affect the overall balance or token distribution.

polkadot address: 14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 28, 2024

User @runcomet, please sign the CLA here.

@runcomet runcomet marked this pull request as ready for review November 5, 2024 20:30
@runcomet runcomet requested review from cheme and a team as code owners November 5, 2024 20:30
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 5, 2024 20:31
@runcomet
Copy link
Contributor Author

Balances of dev_accounts should not be included in the total issuance? @ggwpez

@runcomet runcomet changed the title Balances: Allow Configurable Number of Genesis Accounts with Specified Balances for Benchmarking Balances: Configurable Number of Genesis Accounts with Specified Balances for Benchmarking Nov 30, 2024
@michalkucharczyk michalkucharczyk added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 14, 2025
@runcomet
Copy link
Contributor Author

please review @michalkucharczyk @skunert

@runcomet
Copy link
Contributor Author

please review @bkchr @acatangiu

@skunert
Copy link
Contributor

skunert commented Jan 23, 2025

@acatangiu @bkontur We need a bridges approval here because this touches some bridge-owned files. This PR helps us to simulate large states in various situations such as benchmarking and also for transactions tests. Approval would be appreciated, I'd like to merge this soon.

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the very trivial bridges and xcm related changes

@skunert skunert enabled auto-merge January 23, 2025 09:40
@skunert skunert added this pull request to the merge queue Jan 23, 2025
Merged via the queue into paritytech:master with commit 04847d5 Jan 23, 2025
200 of 204 checks passed
@runcomet
Copy link
Contributor Author

Thanks for the review!

Glad to see this merged🎉

@runcomet
Copy link
Contributor Author

please see my Polkadot address in the description @ggwpez @bkchr

@bkchr
Copy link
Member

bkchr commented Jan 26, 2025

/tip small

Copy link

@bkchr A referendum for a small (20 DOT) tip was successfully submitted for @runcomet (14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg on polkadot).

Referendum number: 1402.
tip

Copy link

The referendum has appeared on Polkassembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balances: Arbitrary number of genesis accounts
6 participants