Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added foreign locations to local accounts converter to all the parachains #5765

Merged
merged 38 commits into from
Oct 2, 2024
Merged

Added foreign locations to local accounts converter to all the parachains #5765

merged 38 commits into from
Oct 2, 2024

Conversation

x3c41a
Copy link
Contributor

@x3c41a x3c41a commented Sep 19, 2024 •
edited by acatangiu
Loading

Added HashedDescription<AccountId, DescribeFamily<DescribeAllTerminal>> foreign locations to local accounts converter to all the parachains.

franciscoaguirre
franciscoaguirre reviewed Sep 19, 2024
View reviewed changes
prdoc/pr_5765.prdoc Outdated Show resolved Hide resolved
prdoc/pr_5765.prdoc Outdated Show resolved Hide resolved
prdoc/pr_5765.prdoc Show resolved Hide resolved
acatangiu
acatangiu requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

Do not remove existing converters to maintain backwards compatibility (see following comments)

Testing

For each chain/runtime, please add unit tests (faster/easier than emulated tests) that cover the newly supported conversions.

E.g. you can add new test for asset-hub-westend here, then run it with cargo test -r -p asset-hub-westend-runtime. Do the same for other runtimes too.

In terms of how to test, very easy way is using LocationToAccountHelper::convert_location()` and pass it locations that use to fail conversion, but with your change now succeed.

You can see an example of how to call LocationToAccountHelper here.

cumulus/parachains/runtimes/people/people-rococo/src/xcm_config.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/people/people-westend/src/xcm_config.rs Outdated Show resolved Hide resolved
@bkontur
Copy link
Contributor

bkontur commented Sep 19, 2024

bot fmt

@paritytech paritytech deleted a comment from command-bot bot Sep 19, 2024
@paritytech paritytech deleted a comment from command-bot bot Sep 19, 2024
@x3c41a
Copy link
Contributor Author

x3c41a commented Sep 20, 2024

Request changes

Do not remove existing converters to maintain backwards compatibility (see following comments)

Testing

For each chain/runtime, please add unit tests (faster/easier than emulated tests) that cover the newly supported conversions.

E.g. you can add new test for asset-hub-westend here, then run it with cargo test -r -p asset-hub-westend-runtime. Do the same for other runtimes too.

In terms of how to test, very easy way is using LocationToAccountHelper::convert_location()` and pass it locations that use to fail conversion, but with your change now succeed.

You can see an example of how to call LocationToAccountHelper here.

Added the tests. Additionally removed my change and made sure that the tests fail.

@x3c41a x3c41a added A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix T6-XCM This PR/Issue is related to XCM. and removed A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix labels Sep 20, 2024
@github-actions github-actions bot requested a review from acatangiu September 30, 2024 07:55
@github-actions GitHub Actions
Copy link
Contributor

Review required! Latest push from author must always be reviewed

@github-actions github-actions bot requested a review from acatangiu September 30, 2024 17:09
@x3c41a x3c41a enabled auto-merge September 30, 2024 17:44
@x3c41a x3c41a disabled auto-merge October 1, 2024 11:45
@github-actions github-actions bot requested a review from acatangiu October 1, 2024 14:10
@x3c41a x3c41a enabled auto-merge October 1, 2024 16:13
@github-actions github-actions bot requested a review from acatangiu October 2, 2024 11:25
@x3c41a x3c41a added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 722b028 Oct 2, 2024
217 of 218 checks passed
@x3c41a x3c41a deleted the location-converter branch October 2, 2024 14:52
This was referenced Oct 17, 2024
Open
Merged
fellowship-merge-bot bot pushed a commit to polkadot-fellows/runtimes that referenced this pull request Nov 28, 2024
@x3c41a
Location conversion tests for relay and parachains (#487)
db4bb53 
Added location convertion tests. 
Polkadot sdk [PR](paritytech/polkadot-sdk#5765)
Fixes #488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkontur bkontur Awaiting requested review from bkontur

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@x3c41a @bkontur @acatangiu @franciscoaguirre