Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes pipeline #5607

Merged
merged 5 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 27 additions & 42 deletions .github/workflows/tests-misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:

test-deterministic-wasm:
timeout-minutes: 20
needs: [ set-image, test-frame-ui ]
needs: [ set-image ]
runs-on: ${{ needs.set-image.outputs.RUNNER }}
container:
image: ${{ needs.set-image.outputs.IMAGE }}
Expand All @@ -144,7 +144,7 @@ jobs:

cargo-check-benches-branches:
needs: [ set-image ]
if: ${{ github.event_name == 'pull_request' }}
if: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}
timeout-minutes: 60
outputs:
branch: ${{ steps.branch.outputs.branch }}
Expand Down Expand Up @@ -354,46 +354,30 @@ jobs:
cp .forklift/config.toml /github/home/.forklift/config.toml
PYTHONUNBUFFERED=x .github/scripts/check-each-crate.py ${{ matrix.index }} ${{ strategy.job-total }}

# TODO: enable when we have a macos Self-Hosted runners
# cargo-check-each-crate-macos:
# timeout-minutes: 120
# needs: [ set-image ]
# runs-on: macos-latest
# env:
# RUSTFLAGS: "-D warnings"
# CI_JOB_NAME: cargo-check-each-crate
# IMAGE: ${{ needs.set-image.outputs.IMAGE }}
# strategy:
# fail-fast: false
# matrix:
# index: [ 1,2,3,4,5,6,7,8,9,10 ] # 10 parallel jobs
# steps:
# - name: Checkout
# uses: actions/[email protected]
#
# - run: |
# VERSION=$(echo $IMAGE | sed -E 's/.*:bullseye-([^-]+)-.*/\1/')
# echo $VERSION
# echo "VERSION=$VERSION" >> $GITHUB_ENV
#
# - run: |
# rustup install $VERSION
# rustup default $VERSION
#
# - name: Check Rust
# run: |
# rustup show
# rustup +nightly show
#
# - name: MacOS Deps
# run: |
# brew install protobuf openssl pkg-config zlib xz zstd llvm jq curl gcc make cmake
# rustup target add wasm32-unknown-unknown --toolchain $VERSION
# rustup component add rust-src rustfmt clippy --toolchain $VERSION
#
# - name: script
# run: |
# PYTHONUNBUFFERED=x .github/scripts/check-each-crate.py ${{ matrix.index }} ${{ strategy.job-total }} True
# cargo-check-each-crate-macos:
# timeout-minutes: 120
# needs: [ set-image ]
# runs-on: macOS
# env:
# RUSTFLAGS: "-D warnings"
# CI_JOB_NAME: cargo-check-each-crate
# IMAGE: ${{ needs.set-image.outputs.IMAGE }}
# strategy:
# fail-fast: false
# matrix:
# index: [ 1,2,3,4,5,6,7,8,9,10 ] # 10 parallel jobs
# steps:
# - name: Checkout
# uses: actions/[email protected]

# - name: Install dependencies
# uses: ./.github/actions/set-up-mac
# with:
# IMAGE: ${{ needs.set-image.outputs.IMAGE }}

# - name: script
# run: |
# PYTHONUNBUFFERED=x .github/scripts/check-each-crate.py ${{ matrix.index }} ${{ strategy.job-total }} True

confirm-required-test-misc-jobs-passed:
runs-on: ubuntu-latest
Expand All @@ -408,6 +392,7 @@ jobs:
- test-node-metrics
- check-tracing
- cargo-check-each-crate
- test-deterministic-wasm
# - cargo-hfuzz remove from required for now, as it's flaky
steps:
- run: echo '### Good job! All the required tests passed 🚀' >> $GITHUB_STEP_SUMMARY
5 changes: 5 additions & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -288,3 +288,8 @@ cancel-pipeline-build-short-benchmark:
extends: .cancel-pipeline-template
needs:
- job: build-short-benchmark

cancel-pipeline-cargo-check-each-crate-macos:
extends: .cancel-pipeline-template
needs:
- job: cargo-check-each-crate-macos
22 changes: 22 additions & 0 deletions .gitlab/pipeline/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,25 @@ quick-benchmarks-omni:
script:
- time cargo build --locked --quiet --release -p asset-hub-westend-runtime --features runtime-benchmarks
- time cargo run --locked --release -p frame-omni-bencher --quiet -- v1 benchmark pallet --runtime target/release/wbuild/asset-hub-westend-runtime/asset_hub_westend_runtime.compact.compressed.wasm --all --steps 2 --repeat 1 --quiet

cargo-check-each-crate-macos:
stage: test
extends:
- .docker-env
- .common-refs
- .run-immediately
# - .collect-artifacts
before_script:
# skip timestamp script, the osx bash doesn't support printf %()T
- !reference [.job-switcher, before_script]
- !reference [.rust-info-script, script]
- !reference [.pipeline-stopper-vars, script]
variables:
SKIP_WASM_BUILD: 1
script:
# TODO: use parallel jobs, as per cargo-check-each-crate, once more Mac runners are available
# - time ./scripts/ci/gitlab/check-each-crate.py 1 1
- time cargo check --workspace --locked
timeout: 2h
tags:
- osx
Loading