Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing features in templates' node packages #5294

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Aug 8, 2024

Corrects the issue we had here, in which cargo build --release worked but cargo build --package parachain-template-node --release failed with missing features.

The command has been added to CI to make sure it works, but at the same we're changing it in the readme to just cargo build --release for simplification.

Labeling silent because those packages are un-published as part of the regular release process.

@rzadp rzadp added the R0-silent Changes should not be mentioned in any release notes label Aug 8, 2024
…ks,std --left-side-feature-missing=ignore --left-side-outside-workspace=ignore --feature-enables-dep=try-runtime:frame-try-runtime,runtime-benchmarks:frame-benchmarking --fix
@shawntabrizi
Copy link
Member

I ran:

zepter lint propagate-feature --features=try-runtime,runtime-benchmarks,std --left-side-feature-missing=ignore --left-side-outside-workspace=ignore --feature-enables-dep=try-runtime:frame-try-runtime,runtime-benchmarks:frame-benchmarking --fix

Which caught some more missing features.

I suspected there were missing features because there were more features added in the PR here: https://github.com/paritytech/polkadot-sdk-parachain-template/pull/10/files

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@rzadp
Copy link
Contributor Author

rzadp commented Aug 9, 2024

I wondered why the zepter check is green on master, and I guess it's because of this.

@ggwpez
Copy link
Member

ggwpez commented Aug 9, 2024

I wondered why the zepter check is green on master, and I guess it's because of this.

Yes it is intended behaviour - last time i tried to add this there was some pushback... can try again though.

@ggwpez
Copy link
Member

ggwpez commented Aug 9, 2024

Yea the diff of adding all feature propagations is a +13K lines, not sure if worth it: https://github.com/paritytech/polkadot-sdk/compare/oty-all-features

@shawntabrizi
Copy link
Member

shawntabrizi commented Aug 9, 2024

@ggwpez i think if you want to get to the point where the whole repo is formatted, you should have like a daily script which does just one crate per day, allows people to review in chunks, and eventually get to the point we want.

But most of those changes look good to me, so I dont see why we wouldnt just merge it.

@rzadp rzadp added this pull request to the merge queue Aug 9, 2024
Merged via the queue into master with commit 149c709 Aug 9, 2024
163 of 167 checks passed
@rzadp rzadp deleted the rzadp/update-templates branch August 9, 2024 16:48
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Aug 28, 2024
Corrects the issue we had
[here](paritytech/polkadot-sdk-parachain-template#10),
in which `cargo build --release` worked but `cargo build --package
parachain-template-node --release` failed with missing features.

The command has been added to CI to make sure it works, but at the same
we're changing it in the readme to just `cargo build --release` for
simplification.

Labeling silent because those packages are un-published as part of the
regular release process.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Shawn Tabrizi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants