-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing features in templates' node packages #5294
Conversation
…ks,std --left-side-feature-missing=ignore --left-side-outside-workspace=ignore --feature-enables-dep=try-runtime:frame-try-runtime,runtime-benchmarks:frame-benchmarking --fix
I ran:
Which caught some more missing features. I suspected there were missing features because there were more features added in the PR here: https://github.com/paritytech/polkadot-sdk-parachain-template/pull/10/files |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
I wondered why the zepter check is green on master, and I guess it's because of this. |
Yes it is intended behaviour - last time i tried to add this there was some pushback... can try again though. |
Yea the diff of adding all feature propagations is a +13K lines, not sure if worth it: https://github.com/paritytech/polkadot-sdk/compare/oty-all-features |
@ggwpez i think if you want to get to the point where the whole repo is formatted, you should have like a daily script which does just one crate per day, allows people to review in chunks, and eventually get to the point we want. But most of those changes look good to me, so I dont see why we wouldnt just merge it. |
Corrects the issue we had [here](paritytech/polkadot-sdk-parachain-template#10), in which `cargo build --release` worked but `cargo build --package parachain-template-node --release` failed with missing features. The command has been added to CI to make sure it works, but at the same we're changing it in the readme to just `cargo build --release` for simplification. Labeling silent because those packages are un-published as part of the regular release process. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Corrects the issue we had here, in which
cargo build --release
worked butcargo build --package parachain-template-node --release
failed with missing features.The command has been added to CI to make sure it works, but at the same we're changing it in the readme to just
cargo build --release
for simplification.Labeling silent because those packages are un-published as part of the regular release process.