-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coretime auto-renew #4424
Merged
Merged
Coretime auto-renew #4424
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
afb5e75
start
Szegoo 2716e0f
setup
Szegoo e443c9e
outlining the main logic
Szegoo 2a8a68b
bounded vec
Szegoo 8df2f81
resolvinig some todos
Szegoo 82859ad
auto-renew for legacy leases
Szegoo e2a4dd5
init test
Szegoo 9c1c7e3
more tests
Szegoo c7ccf5a
enable_auto_renew_renews
Szegoo c3eaa21
different approach
Szegoo edffbfc
docs
Szegoo 68f244c
enable_auto_renewal_with_end_hint_works
Szegoo 893fa9d
auto_renewal_works
Szegoo 0b50a58
progress
Szegoo 9dc9b6a
store account instead of task
Szegoo 9baa77a
fix builds
Szegoo ee7e3c4
disable auto-renewal
Szegoo e0f1c71
disable auto renew test
Szegoo 1a46abc
docs
Szegoo 2f17544
account for changing core indices
Szegoo 63b6f66
fix
Szegoo aaba50d
bench enable_auto_renew
Szegoo 7d682e6
bench disable & auto_renew
Szegoo af8f109
weights
Szegoo f22c451
fix
Szegoo a6c0676
dummy weights
Szegoo a4f3b6c
don't auto renew when not needed
Szegoo 4f18949
fix auto renewal
Szegoo 5d29cd3
more checks
Szegoo 0d9e91d
test fixes/improvements
Szegoo dad2b91
merge
Szegoo 88c9ce1
merge fix
Szegoo 17e0ee5
cleanup | benchmarks: TODO
Szegoo 8be2d02
Update substrate/frame/broker/src/dispatchable_impls.rs
Szegoo c8fa5f8
Update substrate/frame/broker/src/types.rs
Szegoo 7d887ab
Update substrate/frame/broker/src/lib.rs
Szegoo 78a203f
resolve comments
Szegoo 5f02e32
cleanup
Szegoo b0aa972
rename
Szegoo de89f30
comment
Szegoo 7259f41
fix benchmarks
Szegoo 9a23b2f
cleanup
Szegoo 0c4e651
simplify logic
Szegoo ef9c4fb
fix benchmarks
Szegoo 4d35d2b
Merge branch 'master' into auto-renew
Szegoo 15d9e1b
merge fixes
Szegoo eff4ee7
benchmark fix
Szegoo 61f466d
resolve conflicts
Szegoo d2041f1
prdoc
Szegoo 7155233
improve docs
Szegoo 9a90fbd
improve comments
Szegoo 0cf0dad
Merge branch 'master' into auto-renew
Szegoo c1fc125
Merge branch 'master' into auto-renew
Szegoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'master' into auto-renew
- Loading branch information
commit 4d35d2b5fc298c307b2ecc1b5d2ad7c5acf3d5df
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being a doomer, but isn't this super not scalable? As in, up to N renewals can happen at most, and all of it is
on_init
, in a single block?Moreover, if there is congestion (e.g. more than
MaxAutoRenewals
cores that wanna auto-renew), how do we deal with congestion? The right way to solve this kind of issue is to let user compete via more tx-fees.I suppose this is still assuming we will only have a maximum of a few dozen cores that want to auto-renew, which is fine, but I think we could have done a bit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right; there is an assumption that there is a fairly limited number of cores and also a limited amount that will own an entire core and do auto-renewals. However, what you mentioned is valid, but I don't think this will be an issue until the number of available cores drastically increases.
I am not really sure what you meant by 'let users compete via more tx-fees.'