Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract pallet-paras-sudo-wrapper into a Separate Crate Trasparently #3882

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

asiniscalchi
Copy link
Contributor

@asiniscalchi asiniscalchi commented Mar 28, 2024

Description

This PR separates pallet-paras-sudo-wrapper into its own crate while keeping the refactor transparent to the code outside polkadot-runtime-common. By re-exporting the pallet in polkadot-runtime-common, external references remain unchanged, preserving backward compatibility and minimizing impact on the wider Polkadot codebase.

Changes Summary:

  • Crate Creation: Extracted pallet-paras-sudo-wrapper to a standalone crate, including a dedicated Cargo.toml for dependencies and configurations.
  • Re-export in polkadot-runtime-common: To maintain existing code paths, pallet-paras-sudo-wrapper is re-exported in polkadot-runtime-common, making the refactor invisible to external users.
  • Dependency Adjustments: Updated Cargo.toml in polkadot-runtime-common and top-level workspace to reflect the new crate path for pallet-paras-sudo-wrapper.

This approach enhances modularity without requiring any changes from the rest of the Polkadot codebase.

@asiniscalchi asiniscalchi force-pushed the refactor/extract_pallet_para_sudo_wrapper branch from 143dbe8 to d609fc6 Compare March 28, 2024 23:29
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5692350

@asiniscalchi asiniscalchi changed the title Refactor/extract pallet para sudo wrapper Extract pallet-paras-sudo-wrapper into a Separate Crate Mar 28, 2024
@asiniscalchi asiniscalchi changed the title Extract pallet-paras-sudo-wrapper into a Separate Crate Extract pallet-paras-sudo-wrapper into a Separate Crate Trasparently Mar 28, 2024
@asiniscalchi asiniscalchi marked this pull request as ready for review March 28, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants