-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract pallet-paras-sudo-wrapper
into a Separate Crate Trasparently
#3882
Open
asiniscalchi
wants to merge
26
commits into
paritytech:master
Choose a base branch
from
asiniscalchi:refactor/extract_pallet_para_sudo_wrapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract pallet-paras-sudo-wrapper
into a Separate Crate Trasparently
#3882
asiniscalchi
wants to merge
26
commits into
paritytech:master
from
asiniscalchi:refactor/extract_pallet_para_sudo_wrapper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143dbe8
to
d609fc6
Compare
The CI pipeline was cancelled due to failure one of the required jobs. |
pallet-paras-sudo-wrapper
into a Separate Crate
pallet-paras-sudo-wrapper
into a Separate Cratepallet-paras-sudo-wrapper
into a Separate Crate Trasparently
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates
pallet-paras-sudo-wrapper
into its own crate while keeping the refactor transparent to the code outsidepolkadot-runtime-common
. By re-exporting the pallet inpolkadot-runtime-common
, external references remain unchanged, preserving backward compatibility and minimizing impact on the wider Polkadot codebase.Changes Summary:
pallet-paras-sudo-wrapper
to a standalone crate, including a dedicatedCargo.toml
for dependencies and configurations.polkadot-runtime-common
: To maintain existing code paths,pallet-paras-sudo-wrapper
is re-exported inpolkadot-runtime-common
, making the refactor invisible to external users.Cargo.toml
inpolkadot-runtime-common
and top-level workspace to reflect the new crate path forpallet-paras-sudo-wrapper
.This approach enhances modularity without requiring any changes from the rest of the Polkadot codebase.